Editorial review: Add precommitHandler() and other info to Navigation API docs #41524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdavidmills
requested review from
sideshowbarker
and removed request for
a team
chrisdavidmills
changed the title
|
Preview URLs
(comment last updated: 2025-10-23 07:08:27) |
noamr
reviewed
Oct 14, 2025
noamr
reviewed
Oct 20, 2025
Co-authored-by: Noam Rosenthal <[email protected]>
|
@noamr thanks for the reviews. This one looks about ready to go on to the editorial review stage now, but feel free to add more comments if you think anything else still needs attention. |
chrisdavidmills
changed the title
Yes, technical LGTM from me! |
sideshowbarker
approved these changes
Oct 23, 2025
Co-authored-by: sideshowbarker <[email protected]>
Co-authored-by: sideshowbarker <[email protected]>
Co-authored-by: sideshowbarker <[email protected]>
Co-authored-by: sideshowbarker <[email protected]>
Co-authored-by: sideshowbarker <[email protected]>
Co-authored-by: sideshowbarker <[email protected]>
Co-authored-by: sideshowbarker <[email protected]>
Co-authored-by: sideshowbarker <[email protected]>
Co-authored-by: sideshowbarker <[email protected]>
|
Looking good; thanks for the review, @sideshowbarker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chromium 141 adds support for the
precommitHandleroption of theNavigateEvent.intercept()method. See https://chromestatus.com/feature/5134734612496384.This PR adds documentation for it.
It also overhauls the
intercept()method page in general, adding a bunch of details in a large "Description" section that was missing before. I think more work needs to be done here, but it is out of the scope of this PR for me to try to fix everything. For now, I've added a bit more information about how theintercept()features work so that the page is a bit more informative.Motivation
Additional details
Related issues and pull requests